Repository navigation
Conversation
Add user-scoped `memory_search` and `memory_ingest` tools for AI SDK 6 through `@atomicmemory/vercel-ai-sdk/tools`. Rename the Vercel adapter to `@atomicmemory/vercel-ai-sdk` and support `new MemoryClient()` with Cloud defaults and the server's `ATOMICMEMORY_API_KEY`. The application binds user identity outside model arguments. Tools validate arguments, bound search output while retaining retrieval evidence, sanitize failures, forward cancellation, and reject pending HTTP 202 ingest responses. The framework-free root entry keeps AI SDK and Zod optional. Include a runnable workspace example and packed-consumer CI for AI SDK 6.0.0/6.0.300 with Zod 3.25.76/4.1.8/4.6.5. Source prepares SDK 1.1.2 and adapter 0.1.2; registry publication remains pending. Validation: source CI passes, including the restarted merged-head run. The separate terminal showcase passes four tests, process-restart recall smoke, TypeScript and formatting checks against the combined implementation. Public PR CI must pass before merge. Local fixtures do not verify hosted persistence or actual engine correction.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 43b166dca6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| } | ||
|
|
||
| function projectHit(hit: z.infer<typeof hitSchema>, budget: number): MemorySearchHit { | ||
| const content = cutText(hit.memory.content, Math.min(MAX_HIT_CONTENT, budget)); |
There was a problem hiding this comment.
When a stored memory contains prompt-control text or model-facing markup, this path only truncates it and then returns it verbatim in the memory_search tool result, so the model receives the hostile content as part of its next prompt and may follow it despite the tool description calling it reference data. Route every retrieved hit through the shared memory→model sanitizer and add an adversarial test against the AI SDK model prompt rather than testing only field allowlisting and length bounds.
AGENTS.md reference: AGENTS.md:L49-L58
Useful? React with 👍 / 👎.
1 participant
Add user-scoped
memory_searchandmemory_ingesttools for AI SDK 6 through@atomicmemory/vercel-ai-sdk/tools. Rename the Vercel adapter to@atomicmemory/vercel-ai-sdkand supportnew MemoryClient()with Cloud defaults and the server'sATOMICMEMORY_API_KEY.The application binds user identity outside model arguments. Tools validate arguments, bound search output while retaining retrieval evidence, sanitize failures, forward cancellation, and reject pending HTTP 202 ingest responses. The framework-free root entry keeps AI SDK and Zod optional.
Include a runnable workspace example and packed-consumer CI for AI SDK 6.0.0/6.0.300 with Zod 3.25.76/4.1.8/4.6.5. Source prepares SDK 1.1.2 and adapter 0.1.2; registry publication remains pending.
Validation: source CI passes, including the restarted merged-head run. The separate terminal showcase passes four tests, process-restart recall smoke, TypeScript and formatting checks against the combined implementation. Public PR CI must pass before merge. Local fixtures do not verify hosted persistence or actual engine correction.