Repository navigation
Conversation
Add user-scoped `memory_search` and `memory_ingest` tools for AI SDK 6 through `@atomicmemory/vercel-ai-sdk/tools`. Rename the Vercel adapter to `@atomicmemory/vercel-ai-sdk` and support `new MemoryClient()` with Cloud defaults and the server's `ATOMICMEMORY_API_KEY`. The application binds user identity outside model arguments. Tools validate arguments, bound search output while retaining retrieval evidence, sanitize failures, forward cancellation, and reject pending HTTP 202 ingest responses. The framework-free root entry keeps AI SDK and Zod optional. Include a runnable workspace example and packed-consumer CI for AI SDK 6.0.0/6.0.300 with Zod 3.25.76/4.1.8/4.6.5. Source prepares SDK 1.1.2 and adapter 0.1.2; registry publication remains pending. Validation: source CI passes, including all checks for the deterministic transport-timeout test repair. That test now triggers cancellation after the local server receives the request, avoiding a wall-clock race while retaining the same scope and safe-error assertions. The separate terminal showcase passes four tests, process-restart recall smoke, TypeScript and formatting checks against the combined implementation. Public PR CI must pass before merge. Local fixtures do not verify hosted persistence or actual engine correction.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add user-scoped
memory_searchandmemory_ingesttools for AI SDK 6 through@atomicmemory/vercel-ai-sdk/tools. Rename the Vercel adapter to@atomicmemory/vercel-ai-sdkand supportnew MemoryClient()with Cloud defaults and the server'sATOMICMEMORY_API_KEY.The application binds user identity outside model arguments. Tools validate arguments, bound search output while retaining retrieval evidence, sanitize failures, forward cancellation, and reject pending HTTP 202 ingest responses. The framework-free root entry keeps AI SDK and Zod optional.
Include a runnable workspace example and packed-consumer CI for AI SDK 6.0.0/6.0.300 with Zod 3.25.76/4.1.8/4.6.5. Source prepares SDK 1.1.2 and adapter 0.1.2; registry publication remains pending.
Validation: source CI passes, including all checks for the deterministic transport-timeout test repair. That test now triggers cancellation after the local server receives the request, avoiding a wall-clock race while retaining the same scope and safe-error assertions. The separate terminal showcase passes four tests, process-restart recall smoke, TypeScript and formatting checks against the combined implementation. Public PR CI must pass before merge. Local fixtures do not verify hosted persistence or actual engine correction.