Repository navigation
media: apple: isp: reject overlapping IPC rings - #218
Closed
RyanTheTide wants to merge 1 commit into
Closed
RyanTheTide wants to merge 1 commit into
RyanTheTide wants to merge 1 commit into
Conversation
A channel ring can currently overlap another ring or the channel table, boot arguments and command storage while still translating inside the IPC surface. Publishing a response then corrupts unrelated protocol storage. Unaligned starts also reach the aligned u64 publication store. Keep the boot storage span validated in stage2 and reject invalid ring extents before initializing them. Preserve full 64-bit addresses and shared doorbell sources. Use subtraction for extent bounds and overlap checks so firmware-selected addresses cannot wrap those calculations. Add six device-independent KUnit cases, including the parsed seven-ring J616s 25G76 geometry above 1 TB. They pass in x86 QEMU; the complete ISP directory compiles for ARM64. No new SoC match or device activation is added. Hardware runtime regression has not been performed. Signed-off-by: Ryan Murray <ryan@aurorasilicon.org> Assisted-by: LLM
RyanTheTide
force-pushed
the
j616s-isp-contracts
branch
from
October 13, 2026 15:25
d169aa8 to
5128682
Compare
Contributor
Author
|
Consolidated into PR #231 at a4e7ee8. All ten added source/config/build blocks from this PR remain verbatim in that head; the IPC layout helper and KUnit test blobs are identical. The replacement also carries the broader gated J616s integration. This closes duplicate tracking without claiming that #231 is hardware-qualified or canonically merged; immutable history is preserved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ISP channel parser currently permits a ring to overlap another ring or the channel table, boot arguments and command area. A response publication can then overwrite unrelated protocol storage. Unaligned starts also reach the aligned u64 publication store.
Reject these layouts before ring initialization, preserve full 64-bit IOVAs, and record the boot storage span validated in stage2. Doorbell sources may remain shared. No SoC match data, DTS activation or firmware payload is added.
Validation:
This is parser groundwork. It does not qualify Linux camera operation on J616s or any new hardware lifecycle.