Repository navigation
drm/apple: reject unimplemented external H17P VRR - #294
Closed
RyanTheTide wants to merge 1 commit into
Closed
RyanTheTide wants to merge 1 commit into
RyanTheTide wants to merge 1 commit into
Conversation
External H17P mode parsing copies the sink adaptive-sync range into modes, so get_modes advertises VRR capability. The external modeset path skips adaptive-sync programming, but atomic checks still accept VRR_ENABLED. Keep those timings available as fixed refresh modes without exposing VRR, and reject external H17P atomic requests that enable it. Preserve legacy and internal mode parsing. Exercise the production binary parser and atomic admission check, including plane-only commits and link recovery. Signed-off-by: Ryan Murray <ryan@aurorasilicon.org> Assisted-by: LLM
RyanTheTide
force-pushed
the
fix/h17p-external-vrr-capability-20261013
branch
from
October 13, 2026 15:20
c2d0e46 to
ca54cc8
Compare
Contributor
Author
|
Consolidated into Linux #293 at 83adf04. The atomic external-VRR refusal is identical after the existing external-profile enum rename, and the parser still withholds unsupported external VRR ranges. The compact standard vrr-rejection regression retains coverage; the old one-off diagnostic path is retired. This closes duplicate work and preserves history; #293 remains responsible for final recovery qualification and aurora-wip integration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
External H17P mode parsing exposes a sink adaptive-sync range even though the external modeset path skips adaptive-sync programming. Atomic requests can consequently enable a feature the driver does not implement.
Keep these timings available as fixed refresh modes, omit the external H17P VRR range and reject external H17P atomic requests that enable VRR, including plane-only commits. Preserve internal and legacy behavior.
Validation: 156 production binary-parser cases, 72 production atomic-admission cases, EDID/metadata lifetime tests and an ARM64 W=1 module build pass. Independent adverse review and physical integration qualification are in progress; keep draft. This change does not implement VRR or remove high fixed refresh modes.