Repository navigation
usb: dwc3: Export dwc3_event_buffers_cleanup() (fixes DWC3_APPLE=m build) - #321
Merged
Merged
Conversation
The Apple glue calls dwc3_event_buffers_cleanup() when it stops the core, but the function is not exported. With USB_DWC3=y and USB_DWC3_APPLE=m (or both modular) modpost fails: ERROR: modpost: "dwc3_event_buffers_cleanup" [drivers/usb/dwc3/dwc3-apple.ko] undefined! Export it like the other core helpers the glue drivers use (dwc3_enable_susphy(), dwc3_core_exit()). Fixes: f5afac9 ("drm/apple: compose lean J700 display and automatic recovery candidate") Assisted-by: LLM Signed-off-by: Ryan Murray <ryan@aurorasilicon.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
dwc3-apple.ccallsdwc3_event_buffers_cleanup()when it stops the core, but dwc3 core does not export it. A config withUSB_DWC3=yandUSB_DWC3_APPLE=m(or both modular) therefore fails at modpost. This was reported in #275:The fix exports it with
EXPORT_SYMBOL_GPL, like the other core helpers the glue drivers use (dwc3_enable_susphy(),dwc3_core_exit()). Fixes: f5afac9.Tests (build-only fix)
USB_DWC3=y,USB_DWC3_APPLE=mdwc3-apple.kolinks=y/=y)CONFIG_MATCHES_PUBLISHED)dwc3_apple_state), all passing.checkpatch --strictis clean apart from the quoted error line and the acceptedAssisted-byformat.Risk
LOW. Export only.
🤖 Generated with Claude Code