Repository navigation
m4pro batch 2 review fixups: keep T8140 ISP and G13/G14 queue priority unchanged - #399
Merged
RyanTheTide merged 2 commits intoOct 23, 2026
Merged
Conversation
…aths Two changes in the T6040 series also act on the T8140 (MacBook Neo), which runs the same H17 firmware interface: - Commit ed7b2a4 ("media: apple: isp: Zero the lens shading strides of H17 setfiles") rewrites the lens shading records of every setfile loaded on H17 firmware. It was only seen to matter on T6040, and the T8140 camera streams with its setfiles unchanged. - Commit 3161362 ("media: apple: isp: Add T6040 support") reads a "data" memory-region for every SoC, maps zeroed pages above it, and fails the probe when it does not fit the heap. The T8140 regions come from the bootloader, and nothing has checked how that would behave there. Limit both to ISP_GEN_T6040, so the T8140 boot and capture paths stay as they were until they are tested on that machine. Assisted-by: LLM Signed-off-by: Ryan Murray <ryan@aurorasilicon.org>
Commit 2321a1b ("drm/asahi: allow HIGH queue priority with CAP_SYS_NICE or DRM master") makes queue_create accept HIGH on every GPU, and its message says the G13 and G14 priority-1 pipes it then reaches are untested. Those are the M1 and M2 Macs, which run Asahi's firmware tables, and a Mesa that starts asking for HIGH would move compositor work onto them. Accept HIGH only on G17, where it was run, and keep EINVAL elsewhere, as before. Assisted-by: LLM Signed-off-by: Ryan Murray <ryan@aurorasilicon.org>
This was referenced Oct 23, 2026
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two follow-ups from reviewing jgoyvaerts' M4 Pro batch (#383 to #387, #391), all merged now. Both keep shared paths on our existing machines where they were until someone tests them there.
ISP_GEN_T6040. The Neo's camera boot and capture paths stay exactly as they were.queue_createaccept HIGH priority on every GPU, and its own message says the G13/G14 priority-1 pipes it then uses are untested. Those are the M1 and M2. This keeps HIGH working on G17, where it was tested, and keeps the old EINVAL everywhere else.Tested in the 73m kernel (Fedora base plus asahi.config, the same resolved config as 73r) with all of batch 2:
🤖 Generated with Claude Code