Skip to content

arm64: configs: enable dependencies of the Asahi default thermal governor - #438

Closed
RyanTheTide wants to merge 1 commit into
integration/aurorafrom
ryan/t-3028-universal-governor
Closed

RyanTheTide wants to merge 1 commit into
integration/aurorafrom
ryan/t-3028-universal-governor

Conversation

@RyanTheTide

@RyanTheTide RyanTheTide commented Oct 25, 2026 •

Copy link
Copy Markdown
Contributor

The shared Asahi fragment selects the power allocator as the default thermal governor, but a Fedora base explicitly disables the governor itself. Olddefconfig therefore drops the requested default and falls back to step-wise. Defconfig already enables the governor, which hid the difference.

Enable the governor and its energy-model dependency in the common fragment. Both defconfig and Fedora-base resolution preserve every setting requested by asahi.config. No per-device config is added.

Both recipes pass the full Image/modules/DTB build with WERROR enabled, including KUNIT=m in the Fedora recipe. Asahi KUnit passes 86/86, apple-dcp host tests pass 63/63, and checkpatch is clean. The combined source is 031f7dec92a1bef6b72509b08c5c597f50474adb, tree 36854d3a72e4efdf2c352166498ab436adaf3c48.

The same image passed approved M1 Pro and M2 one-shot checks against fresh normal baselines. Native GPU compute/readback verified all 4096 words on each device, kernel fault counters stayed at zero, and baseline devices, active services and SELinux enforcing were preserved. Both machines are back on 73w with the checks passing again and test kernels/entries/fallback units removed. The M1 Pro checks used ten CPUs, appledrm and stock boot.bin.

This remains draft for the required common-config review by DJ. No merge has been performed.

The shared fragment requests the power allocator as the default thermal
governor but does not enable the governor itself. A Fedora base explicitly
disables THERMAL_GOV_POWER_ALLOCATOR, so olddefconfig drops the requested
default and falls back to step-wise. Defconfig happens to enable it.

Enable the governor and its energy-model dependency in the common
fragment. This keeps the requested hardware default available on both
defconfig and distribution bases without a device-specific configuration.

Assisted-by: LLM
Signed-off-by: Ryan Murray <ryan@aurorasilicon.org>
@RyanTheTide

RyanTheTide commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor Author

This is the right small dependency fix. THERMAL_DEFAULT_GOV_POWER_ALLOCATOR depends on THERMAL_GOV_POWER_ALLOCATOR, which depends on ENERGY_MODEL. Both gate bases already supply CPU_FREQ. Original Fedora resolution drops the requested default; these two common-fragment settings preserve it without a per-device config.

On integration/aurora at 421e314 with shared #438 and #456, DCP is PASS (63/63). KUnit has 905 passes and 1 policy skips. Universal WERROR is PASS; Fedora-base WERROR is PASS. All 129 requested Asahi settings survive the qualified recipes when both config-resolution checks pass. The exact original a2a5040 patch is reused throughout the matrix. Native thermal behavior remains part of the orchestrator's hardware qualification.

@RyanTheTide

Copy link
Copy Markdown
Contributor Author

Merged into aurora-wip through #534 (2026-10-28 consolidation). aurora-wip is the home for WIP from here on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant