Skip to content

arm64: dts: apple: fix J616s PCI Wi-Fi schema validation - #458

Closed
RyanTheTide wants to merge 2 commits into
integration/aurorafrom
review/j616s-pci-wifi-schema
Closed

RyanTheTide wants to merge 2 commits into
integration/aurorafrom
review/j616s-pci-wifi-schema

Conversation

@RyanTheTide

@RyanTheTide RyanTheTide commented Oct 25, 2026 •

Copy link
Copy Markdown
Contributor

The J616s PCI Wi-Fi node only names the Broadcom family, which fails full T6040 DT schema validation. Name the BCM4388 PCI function and retain the family fallback used for country and MAC properties. Allow that pair in the binding and omit the redundant root-port compatible.

This is split from the GPU bring-up because it does not enable the GPU. The GPU review carries it as a prerequisite until this lands. On the combined GPU head a0a9485, dt_binding_check and dt-doc-validate pass for the Wi-Fi binding. The J616s DTB passes CHECK_DTBS and direct validation against the full schema set with an empty diagnostic log. The GPU PR is #463.

Name the BCM4388 PCI function while retaining the family fallback used by
the driver for country and MAC properties. Allow that pair in the binding
and omit the redundant root-port compatible. This is independent of GPU
enablement, split from the J616s bring-up to keep that review focused.

Assisted-by: LLM
Signed-off-by: Ryan Murray <ryan@aurorasilicon.org>
Preserve the existing indent after removing the redundant compatible.

Assisted-by: LLM
Signed-off-by: Ryan Murray <ryan@aurorasilicon.org>
erikwb pushed a commit to erikwb/linux that referenced this pull request Oct 28, 2026
Carry the independent aurora-silicon#458 prerequisite for complete T6040 DT validation.
Keep the PCI identity and family fallback and omit the redundant root-port
compatible. Its diff can disappear once aurora-silicon#458 lands.

Link: aurora-silicon#458

Assisted-by: LLM
Signed-off-by: Ryan Murray <ryan@aurorasilicon.org>
@RyanTheTide

Copy link
Copy Markdown
Contributor Author

J616s check, 2026-10-30 night.

This change is already in integration/aurora as 6741e1e ("arm64: dts: apple: repair the J616s PCI Wi-Fi schema description"), together with the BCM4388 binding entries. Reverse-applying this PR's diff to integration/aurora 7823a6e succeeds for both files, so merging it now would change nothing.

The J616s also already boots this description. Its Stage 2 DTB has compatible = "pci14e4,4434", "brcm,bcm4329-fmac" on wifi@0,0 and no compatible on the root port pci@0,0, which is exactly what this PR produces. On fleet10 (uptime about 4 h) brcmfmac is bound to 01:00.0 (BCM4388 14e4:4434), and wld0 is associated on 5 GHz channel 149 (40 MHz). The J616s reaches the network only over that Wi-Fi link. BT (01:00.1) is up too.

Closing as superseded by 6741e1e.

🤖 Generated with Claude Code

@RyanTheTide
RyanTheTide deleted the review/j616s-pci-wifi-schema branch November 7, 2026 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant