Repository navigation
arm64: configs: drop redundant shared helper requests - #469
Closed
RyanTheTide wants to merge 5 commits into
Closed
RyanTheTide wants to merge 5 commits into
RyanTheTide wants to merge 5 commits into
Conversation
The shared drivers already select keys, AOP, the MAX98357A codec, Rust firmware loading, the Apple mailbox and C RTKit support. Removing these six requests cumulatively changes no resolved symbol over either ARM64 defconfig or the Fedora Asahi base, with WERROR enabled. Keep the drivers and their selections as the source of those dependencies. Assisted-by: LLM Signed-off-by: Ryan Murray <ryan@aurorasilicon.org>
…ected-config-helpers-20261026
Both defconfig and the retained Fedora base already enable ENERGY_MODEL. Removing the extra fragment request leaves the complete resolved config unchanged on both recipes with WERROR. Keep the power allocator governor and its default request. Assisted-by: LLM
…ected-config-helpers-20261026
RyanTheTide
changed the title
Contributor
Author
|
Merged into aurora-wip through #534 (2026-10-28 consolidation). aurora-wip is the home for WIP from here on. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The shared fragment explicitly requests six helpers already selected by its retained drivers. Remove them cumulatively and inherit ENERGY_MODEL from both bases instead of repeating the parent PR's new request. Complete resolutions with WERROR have zero delta on both bases for these removals. Driver requests, thermal policy and deliberate debug choices stay intact.
Stacked on #465; the rest of the series follows this branch.
Validation at 09fe7d9: complete Image/modules/dtbs builds passed with WERROR for both ARM64 defconfig + asahi.config and Fedora-base + asahi.config. Both Apple dtbs_check commands ran; inherited schema diagnostics are retained, with unchanged hardware DTS/schema constraints. QEMU KUnit: 357 passed, 95 skipped, zero failures/crashes/errors. Required SIO, thermal, USER4K and applicable Asahi suites execute. The full apple-dcp host suite passes 63/63, with source/tree/compiler/time/checksum receipts. Complete resolved configs preserve every enabled driver.
Hardware smokes before merge: use the same image on Neo, M1 Pro, M2 and J616s for boot, native display/GPU, protected audio, input, networking, USB, thermal governor/temperature/fan behavior and applicable suspend/refusal behavior. M3 G15/SIO and J713 display/GPU also need affected-device coverage. Keep the previous daily and user sessions available; target operations remain controller-gated. No hardware qualification is claimed.