Repository navigation
Conversation
The driver manages its firmware address space with drm_mm, which is built into the DRM core. Without CONFIG_DRM the link fails: ld.lld: error: undefined symbol: drm_mm_insert_node_in_range ld.lld: error: undefined symbol: drm_mm_remove_node ld.lld: error: undefined symbol: drm_mm_takedown ld.lld: error: undefined symbol: drm_mm_init Real configurations enable DRM for the display, so this shows up only in minimal ones, such as a KUnit configuration for the driver's tests. Depend on DRM. Fixes: a4f0cf2 ("media: apple: Add Apple ISP driver")
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Apple ISP driver manages its firmware address space with
drm_mm, which is built into the DRM core, but its Kconfig does not depend on DRM. WithoutCONFIG_DRMthe kernel fails to link (undefined symbol: drm_mm_initand three more).Real configurations enable DRM for the display, so this only shows up in minimal ones. I hit it with a KUnit configuration for the ISP driver's own tests while working on #531.
Testing
--strict: clean.CONFIG_DRM=y: 13/13 of the ISP suites pass.CONFIG_DRM:CONFIG_VIDEO_APPLE_ISPcannot be enabled, which is the intended result.