Repository navigation
drm/asahi: reserve the M5 UAPI feature bits, command types and bind flag - #568
Merged
Merged
Conversation
The Aurora Mesa that omacom/mesa is syncing (omacom/mesa#19) defines feature bits 17 to 24, 26 and 28, command types 5 to 7 and DRM_ASAHI_BIND_SPARSE_TILE for the M5 (G17G/G17S) runtime. This header defines none of them. Mesa only uses each one after the kernel reports its feature bit, and this kernel never does, so nothing runs today. But if one of those numbers were later given to something else, Mesa would take an M5 path this kernel does not have. Reserve them under Mesa's names and values. Each entry says it belongs to the M5 runtime, and the comment before the feature bits notes that bits 25 and 27 are reserved for it too. This kernel already rejects the command types and the bind flag with EINVAL, and it reports none of the feature bits. Signed-off-by: DjDeveloperr <hey@djdev.me> (cherry picked from omacom/linux-aurora commit 0a449af)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirror of omacom#273 (commit 0a449af there), requested in maralcbr's review of omacom/mesa#19.
aurora-wip Mesa defines these values for the M5 (G17G/G17S) runtime, and this tree's
include/uapi/drm/asahi_drm.hdoesn't have them either:DRM_ASAHI_BIND_SPARSE_TILE.This reserves them under Mesa's names and values, so the numbers can't be reused. Each entry says it belongs to the M5 runtime, and the comment before the feature bits notes that bits 25 and 27 are reserved for it too. This kernel already rejects the command types and the bind flag with EINVAL, and it reports none of the feature bits. Header only; the pick applied without conflicts.
Testing: asahi KUnit (minimal arm64 config with
DRM_ASAHI) passes 188 tests, 186 pass, 2 skip. The names and values match Mesa's header.