Repository navigation
selftests: apple-dcp: give the backlight fixtures the DAC fade fields - #987
Merged
Merged
Conversation
"drm/apple: fade the panel backlight on DAC firmware" added the fade state to struct dcp_brightness and a third delayed work that dcp_backlight_stop() cancels. The panel-takeover-registration and desktop-brightness-notifications fixtures declare their own cut-down struct apple_dcp, so both stopped compiling and the apple-dcp host selftests fell to 83/85. Add the fade fields to both fixtures. The takeover fixture runs only the desktop 26.x path, so the DAC fade helpers it now references assert if they are ever reached, like the other DAC-only stubs there. dcp_backlight_stop() now cancels three delayed works per call, so the notification fixture expects 3 and 6. Fixes: 2924f21 ("drm/apple: fade the panel backlight on DAC firmware") Assisted-by: LLM Signed-off-by: Ryan Murray <81541646+RyanTheTide@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #983 ("drm/apple: fade the panel backlight on DAC firmware") the apple-dcp host selftests are 83/85.
panel-takeover-registrationanddesktop-brightness-notificationsbuild their own cut-downstruct apple_dcp, and it lacks the new fade fields instruct dcp_brightness, so neither compiles.This adds the fields to both fixtures. The takeover fixture only runs the desktop 26.x path, so the DAC fade helpers it now pulls in (
dcp_dac_fade_starts,mod_delayed_work) assert if reached, like the other DAC-only stubs there.dcp_backlight_stop()now cancels three delayed works, so the notification fixture counts 3 and 6.Test only, no kernel code.
run.pyon integration/aurora 2661d71 plus this: 85/85 (83/85 before).🤖 Generated with Claude Code