Repository navigation
Conversation
…FormationTemplate
Opt-in props, off for hotswap:
- strictValues: CloudFormation value semantics (empty strings are values, null is missing),
Fn::Select out of range is an evaluation failure, Fn::Sub handles ${!Literal}
- unavailableParameters: a Ref to one fails instead of falling back to its Default
- lookups (SharedLookups): Cloud Control reads cached per resource and limited across evaluators,
nested stack outputs read from DescribeStacks
Changes that also apply to hotswap (error handling only):
- unsupported functions throw CfnUnsupportedFunctionException (a CfnEvaluationException, same message)
- failed Cloud Control lookups keep the original error as the cause
- a Cloud Control identifier that can't be evaluated throws its own evaluation error; other errors
while building it are still wrapped in a CfnEvaluationException
- Fn::GetAtt of a nested stack output when the nested template has no Outputs is an evaluation failure,
not a TypeError
- parseIntrinsic is exported for reuse
This was referenced Oct 21, 2026
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2074 +/- ##
=======================================
Coverage 92.10% 92.10%
=======================================
Files 82 82
Lines 13186 13186
Branches 1878 1878
=======================================
Hits 12145 12145
Misses 1003 1003
Partials 38 38
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Remove the strictValues option and make its semantics the default:
- an empty string (or 0, false) is a value; only a missing or null value is missing
- Fn::Select with an index out of range is an evaluation failure
- ${!Literal} in Fn::Sub is the literal text ${Literal}
For hotswap, each of these either replaces a wrong value with the correct one (an empty-string parameter
no longer falls back to its Default; Fn::Select out of range no longer becomes an empty string) or turns a
case that fell back to a full deployment into a hotswap with the correct value ("", 0 or false attributes,
${!Literal}). A null attribute is still missing.
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for this change
First of three stacked PRs, which eventually add an unstable
evaluateaction to toolkit-lib (#2066).Given a CloudFormation template,
evaluateresolves that template against deployed resources. This action reusesEvaluateCloudFormationTemplate, which hotswap currently uses. It needs CloudFormation's value semantics, which this PR makes the default; for hotswap these are fixes (see below).Stack:
evaluateactionDescription of changes
New opt-in props on
EvaluateCloudFormationTemplate. Hotswap doesn't set these props.unavailableParameters: aRefto one of these parameters (e.g. NoEcho parameters, whose deployed values are masked) fails instead of falling back to the parameter'sDefault, including where the evaluator uses it internally (Cloud Control identifiers, nested stack parameters).lookups(newSharedLookupsclass): Cloud Control reads are cached per resource and limited to a number in flight across all evaluators that share it, and nested stack outputs are read fromDescribeStacksof the deployed nested stack (by its physical id), instead of evaluated from its template.Changes that also apply to hotswap:
0,false) is a value and only a missing ornullvalue is missing,Fn::Selectout of range is an evaluation failure, andFn::Subtreats${!Literal}as the literal text${Literal}. For hotswap, an empty-string parameter no longer falls back to itsDefault, andFn::Selectout of range no longer becomes an empty string;"",0orfalseattributes and${!Literal}now hotswap instead of falling back to a full deployment.CfnUnsupportedFunctionException.cause.CfnEvaluationException, so hotswap still treats it as non-hotswappable rather than failing the deployment.Fn::GetAttof a nested stack output when the nested template has noOutputssection is an evaluation failure instead of aTypeError(which failed the hotswap deployment).parseIntrinsicis exported, for reuse by the next PR.Describe any new or updated permissions being added
None.
Description of how you validated changes
nullattribute is still missing, and errors while building a Cloud Control identifier still come back asCfnEvaluationException.Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license