Skip to content

feat: Integ conditional fixture setup - #2077

Draft
dgandhi62 wants to merge 7 commits into
mainfrom
integ-conditional-fixture-setup
Draft

dgandhi62 wants to merge 7 commits into
mainfrom
integ-conditional-fixture-setup

Conversation

@dgandhi62

Copy link
Copy Markdown
Contributor

NA

Checklist

  • This change contains a major version upgrade for a dependency and I confirm all breaking changes are addressed
    • Release notes for the new version:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions

Copy link
Copy Markdown
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

An earlier commit also skipped cloneApp and installPackages for these
tests, assuming 'cdk bootstrap' needs neither. Running them against a local
AWS emulator disproved that: with no explicit environment, 'cdk bootstrap'
reads cdk.json and executes the app (node app.js) to resolve the target
environment, so it needs both the cloned app and the installed
aws-cdk-lib/constructs. Skipping those made bootstrap exit 1 with
'Specify an environment name...' and then 'Cannot find module constructs'.

The only setup step these tests genuinely don't use is the public ECR
login (none pulls a public image; they inspect via the SDK). Reduce every
opt-out to setup: { ecrLogin: false } and correct the comments.

This branch had an error being deployed

1 failed (outdated) and 2 active deployments
run-tests — 85421104 Deployed Oct 21, 2026 by dgandhi62 via integ_cli (cli-integ-tests, 24.19, 11) #7387
no-approval — 85421104 Deployed Oct 21, 2026 by dgandhi62 via prepare #7387
automation — b31f328a Deployed Oct 21, 2026 by dgandhi62 via Triage Pull Requests #2234
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants