Repository navigation
fix: correct executable bits on docs and scripts - #281
avneetbansal-aws wants to merge 2 commits into
Conversation
Two pre-commit hooks failed on wrong Unix executable bits: - check-executables-have-shebangs: 6 hyperpod-* `.md` docs were marked executable (100755) with no shebang. Docs should not be executable; cleared the bit (-> 100644). - check-shebang-scripts-are-executable: 9 `.py` scripts have a `#!/usr/bin/env python3` shebang but were not executable; set the bit (-> 100755). (Issue awslabs#215 listed 2; the set has since grown to 9, all with shebangs flagged by the hook on current main.) Fixes awslabs#215
|
This pull request is now marked as stale because it hasn't seen activity for a while. Add a comment or it will be closed soon. If you wish to exclude this issue from being marked as stale, add the "backlog" label. |
|
Closing this pull request as it hasn't seen activity for a while. Please add a comment @mentioning a maintainer to reopen. If you wish to exclude this issue from being marked as stale, add the "backlog" label. |
|
@awslabs/agent-plugins-admins this PR was auto-closed by the stale bot, not for any review reason. It is a small hygiene fix: it corrects the executable bits on docs and scripts so the pre-commit checks (check-executables-have-shebangs / check-shebang-scripts-are-executable) pass. No functional change. Could you reopen and take a look, or let me know if you would prefer I resubmit against a fresh branch? Happy to adjust as needed. |
Fixes #215.
Two pre-commit hooks fail because of wrong Unix executable bits.
check-executables-have-shebangsflags sixhyperpod-*.mddocs that are tracked as executable (100755) with no shebang, andcheck-shebang-scripts-are-executableflags Python scripts that carry a#!/usr/bin/env python3shebang but are not executable. This clears the executable bit on the docs and sets it on the scripts.The issue listed two scripts when it was filed, but the hook now flags nine on current
main, since more scripts were added in the meantime. All nine have shebangs and are flagged, so this fixes the full current set rather than leaving the hook red after a partial fix.Docs that had the executable bit cleared:
Shebang scripts that had the executable bit set:
No file contents changed, only mode bits. Both hooks pass locally after the change.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.