[JosunLP]

Summary

no-value-in-untracked reported every <identifier>.value read inside untrack() / watch*() callbacks and suggested .peek(), without checking that the identifier is a signal. const input = document.querySelector('input'); watch(query, () => search(input.value)); was reported, and the suggestion rewrote it to input.peek(), which throws.

The rule now reports only when scope analysis resolves the identifier to a declaration initialised from a bQuery signal factory, imported from @bquery/bquery, a subpath or /full. Renamed and namespace imports count. The factories are signal, computed, linkedSignal, persistedSignal, readonly, useSignal, useComputed, useSlot, useCookie, reducedMotionSignal, keyboardUserSignal, focusVisible, isActiveSignal, draggablePosition and sortableOrder. Unresolved identifiers and anything else are left alone.

This is the first change after the plugin moved here from bQuery/bQuery#278 (main holds that import).

Changes

• src/rules/no-value-in-untracked.js: resolves the declaration and matches its initialiser against the factory list with the existing matchBQueryCall. as and ! wrappers are unwrapped, and reassigned let/var bindings are skipped.
• Tests:
  • New valid cases: DOM input.value, a Map entry, a plain object, a function parameter, an import from ./state, a non-bQuery signal, bQuery effect(), a reassigned let, a destructured binding.
  • New invalid cases: renamed and namespace imports, /full, useCookie.
  • 7 of the new valid cases fail against the old rule.
• README and CHANGELOG describe what counts as a signal.

Validation

• bun run typecheck, bun run lint, bun run format:check
• CI=true bun test: 108 pass
• bun run check:export-map: up to date, 1145 exports from @bquery/bquery@1.17.2

Notes

• The export map on main is generated from the published @bquery/bquery@1.17.2. It no longer lists the 8 names that only exist unreleased in bQuery dev (createSchemaForm, useSchemaForm, validate, …); they come back when that release is installed and the map is regenerated.
• meta.docs.url points to this repository's README. The bquery.js.org guide still has the full rule docs, so DOCS_BASE in src/utils.js could point there instead.
• Not changed, but worth a look: no-dynamic-trusted-html still flags const html = sanitizeHtml(x); trusted(html), because it only accepts a direct sanitizer call.
• Publishing needs an npm Trusted Publisher for bQuery/eslint-plugin and publish.yml (a manual workflow, dry-run by default).

---

Generated by Claude Code

[coderabbitai]

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

• Configuration used: defaults
• Review profile: CHILL
• Plan: Advanced
• Run ID: 031b31cf-b1c5-4688-af06-8e082c660444

📥 Commits

Reviewing files that changed from the base of the PR and between 6c189b2 and 237c788.

📒 Files selected for processing: 4

• CHANGELOG.md
• README.md
• src/rules/no-value-in-untracked.js
• test/no-value-in-untracked.test.ts

+-----------------------------------------+
| Making HAL 9000 open the pod bay doors. |
+-----------------------------------------+
  \
   \     /)/)
        ( '')
        /  |
      o(___)

✨ Finishing Touches

📝 Generate docstrings

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}