Skip to content

Recognize a complete expression in explicitly consumed lines #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
OskarEichler wants to merge 2 commits into
base: master
Choose a base branch
from
+6 −0
Open

Recognize a complete expression in explicitly consumed lines #88

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e0db3c5
Recognize a complete expression in explicitly consumed lines
OskarEichler Aug 27, 2026
e2c25b4
Add regression coverage for recognize a complete expression in explic…
OskarEichler Aug 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lib/method_source/code_helpers.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,8 @@ def complete_expression?(str)
def extract_first_expression(lines, consume=0, &block)
code = consume.zero? ? +"" : lines.slice!(0..(consume - 1)).join

return code if !code.empty? && complete_expression?(block ? block.call(code) : code)

lines.each do |v|
code << v
return code if complete_expression?(block ? block.call(code) : code)
Expand Down
4 changes: 4 additions & 0 deletions spec/method_source/code_helpers_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,10 @@
@tester = Object.new.extend(MethodSource::CodeHelpers)
end

it "returns a complete explicitly consumed prefix" do
expect(@tester.expression_at("7\n9\n", 1, consume: 1)).to eq("7\n")
end

[
["p = '", "'"],
["def", "a", "(); end"],
Expand Down