fix(L1): bump semver for contracts changed since the last release - #438
Merged
Merged
Conversation
OptimismPortal2, DisputeGameFactory, and AggregateVerifier all have source changes relative to the versions currently deployed onchain, but still declare the same semver. Bump each so the onchain version distinguishes the artifacts. - OptimismPortal2 5.2.0 -> 6.0.0: ETHLockbox removal drops the `ethLockbox()` getter and the `OptimismPortal_InvalidLockboxState` error from the ABI. - DisputeGameFactory 1.4.0 -> 1.5.0: game proxies are now deployed with `cloneDeterministic`; the ABI is unchanged. - AggregateVerifier 0.2.0 -> 0.3.0: reserves 0.2.0 for the v8.3.0 release branch, which ships the schedule-pinning work without the cadence changes. Co-authored-by: Cursor <cursoragent@cursor.com>
Collaborator
✅ Heimdall Review Status
|
0xth4nh
approved these changes
Sep 14, 2026
jackchuma
added a commit
that referenced
this pull request
Sep 17, 2026
main bumped OptimismPortal2 5.2.0 -> 6.0.0 in #438 for the ETHLockbox removal, and this branch independently bumped 5.2.0 -> 6.0.0 for dropping `superchainConfig()`. After merging main both ABIs declare 6.0.0 while differing by that getter, which is the same divergence #438 and #440 set out to remove. Major rather than minor: the removal is a breaking ABI change, matching the reason Co-authored-by: Cursor <cursoragent@cursor.com> #438 took the portal major in the first place.
jackchuma
added a commit
that referenced
this pull request
Sep 17, 2026
* refactor(L1): merge SuperchainConfig into SystemConfig SuperchainConfig held the pause state and the Guardian/Incident Responder roles for a single chain, while every pausable contract reached it by hopping through SystemConfig. Collapsing the two removes a proxy, a shared ProxyAdmin, and an indirection from every `paused()` read. SystemConfig now owns: - `GUARDIAN` / `INCIDENT_RESPONDER` immutables, set via the constructor. - `pauseTimestamps` and the `pause`/`unpause`/`extend` API. - `paused(address)`, `pausable`, `expiration`, and `pauseExpiry` views. The former `superchainConfig` storage slot becomes `spacer_108_0_20` so existing deployments keep their layout, and `pauseTimestamps` is appended. Callers lose their `superchainConfig()` passthroughs (`config()` on DelayedWETH) and read pause state straight off SystemConfig, so their ABIs change and they take major version bumps. `initialize` also drops its `_superchainConfig` argument. Deploy tooling drops the whole superchain stage: no SuperchainConfig implementation, proxy, or dedicated ProxyAdmin, and no separate upgrade step for the shared proxy. The `superchainConfigGuardian` and `superchainConfigIncidentResponder` deploy-config keys are renamed to `guardian` and `incidentResponder` and now feed the SystemConfig constructor. Pause coverage from SuperchainConfig.t.sol moves into SystemConfig.t.sol. Co-authored-by: Cursor <cursoragent@cursor.com> * fix(L1): preserve pause state during upgrade Co-authored-by: Codex <codex-noreply@coinbase.com> * fix(L1): preserve legacy pause records during migration Co-authored-by: Codex <codex-noreply@coinbase.com> * chore(L1): refresh SystemConfig semver-lock hash Co-authored-by: Cursor <cursoragent@cursor.com> * docs(L1): document legacy pause migration risk Co-authored-by: Codex <codex-noreply@coinbase.com> * fix(L1): bump OptimismPortal2 semver for the superchainConfig removal main bumped OptimismPortal2 5.2.0 -> 6.0.0 in #438 for the ETHLockbox removal, and this branch independently bumped 5.2.0 -> 6.0.0 for dropping `superchainConfig()`. After merging main both ABIs declare 6.0.0 while differing by that getter, which is the same divergence #438 and #440 set out to remove. Major rather than minor: the removal is a breaking ABI change, matching the reason Co-authored-by: Cursor <cursoragent@cursor.com> #438 took the portal major in the first place. * test(L1): drop duplicated systemConfig assertions Porting the `superchainConfig()` assertions onto `systemConfig()` left three getter tests asserting the same address twice in a row. Co-authored-by: Cursor <cursoragent@cursor.com> * fix(L1): validate supplied SystemConfig pause authorities The Guardian and Incident Responder are now constructor immutables on the SystemConfig implementation, so when `deploy` is handed a prebuilt implementation set it never reads `implementationsInput.guardian` or `.incidentResponder` at all. A stale implementation therefore installs its own pause authorities and the deploy input silently has no effect. Require a supplied implementation to carry the configured roles, and apply the same non-zero Guardian check that freshly deployed implementations already get, so a chain cannot deploy with nobody able to unpause it. Co-authored-by: Cursor <cursoragent@cursor.com> * docs(L1): name both pause roles in the migration warning Legacy `SuperchainConfig.pause` is gated on `_assertOnlyGuardianOrIncidentResponder`, so the Incident Responder can also open a pause in the window between the check and the upgrade. Co-authored-by: Cursor <cursoragent@cursor.com> * chore(L1): restore semver-lock hashes built from source artifacts A `just snapshots-check-no-build` run after the test-profile build rewrote the ProtocolVersions and TEEProverRegistry initCodeHashes from those artifacts, and they were committed alongside the OptimismPortal2 bump. Regenerated with `just semver-lock`, which force-builds the source graph first. Co-authored-by: Cursor <cursoragent@cursor.com> --------- Co-authored-by: Cursor <cursoragent@cursor.com> Co-authored-by: Codex <codex-noreply@coinbase.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OptimismPortal2,DisputeGameFactory, andAggregateVerifierall have source changes relative to what is currently deployed onchain, but they still declare the same semver. This bumps each one so the onchainversion()actually distinguishes the artifacts.Verified against live contracts on L1 (Base mainnet and Base Sepolia both report the same values):
OptimismPortal25.2.05.2.06.0.0DisputeGameFactory1.4.01.4.01.5.0AggregateVerifier0.2.00.3.0Why each bump
OptimismPortal25.2.0 → 6.0.0 (major). The ETHLockbox removal is an interface break: theethLockbox()getter and theOptimismPortal_InvalidLockboxStateerror are both gone from the ABI, and the storage slot is now a spacer.DisputeGameFactory1.4.0 → 1.5.0 (minor). Game proxies are now deployed viacloneDeterministicinstead ofclone, and the duplicate-UUID check moved so the UUID can serve as the CREATE2 salt. The ABI snapshot is byte-identical, so this is a behavioral change only.AggregateVerifier0.2.0 → 0.3.0 (minor).0.1.0shipped in the v8.2.x tags. Thereleases/v8.3.0branch carries thescheduleId/ProtocolVersionspinning work but reverted the cadence fork-gating in #436, so it is a genuinely different artifact frommain. The backport claims0.2.0for that release, andmain— which is a superset with the cadence work — moves to0.3.0so the two bytecodes do not share a version number.Companion PR
A backport targeting
releases/v8.3.0applies the sameOptimismPortal2andDisputeGameFactorybumps (those two files are identical on both branches) and takesAggregateVerifierfrom0.1.0to0.2.0.Testing
just snapshotsregenerated from a clean build; onlysnapshots/semver-lock.jsonchanges, covering exactly the three contracts. No ABI or storage layout changes, as expected for a version-string-only edit.just test: 1231 passed, 0 failed, 1 skipped.just lint-checkclean.Made with Cursor