check_redfish: stop syncing the live fan reading - #568
Merged
Merged
Conversation
This was referenced Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@marcinpsk raised this on #473: fan speed is a live measurement, so it churns.
Confirmed against a real NetBox 4.7. Bump the reading in the inventory file between two runs and the fan is written again - once per fan, per server, per run, forever, and every one of those lands in the NetBox changelog. It happens on both paths, the inventory item and the module, because both take
speedfrom the same item data.The other components that fill
speedare describing the part rather than measuring it - DIMM clock, drive rpm rating, NIC link speed - so they stay. Only the fan reading is dropped; the fan is still synced with its name, health and physical context.One thing I did not touch: a CPU's
current_speedcould drift the same way on hardware that reports the live clock instead of the rated one. I have no data on that, and nobody has reported it, so I left it alone rather than guess.tests/test_check_redfish_fan_speed.pycollects the same fan at two different rpm and expects one identical item; it fails on development. Suite 145, and the e2e run after an rpm jump now reports no change at all.