Repository navigation
Coverage to 97.9%, DankDash card fit fix and README refresh - #84
Merged
Merged
Conversation
The row count divided the whole card height by the row height, but the card pads its content, so the last row ran into the bottom edge. The usage bars also hardcoded a 4 px height, 2 px radius and 3 px spacing; they now use Theme.spacingS, height / 2 and Theme.spacingXS like the DMS example cards. The runtime test shrinks the card to the smallest height that lists every row and checks the rows keep the card's padding. Signed-off-by: Bernardo Pinto Gomes <bernardopgomes@hotmail.com>
kcov 43 loses bash line tracking after a multi-line quoted argument with a single quote, which hid most of the Hermes and OpenCode SQL paths. CI now builds kcov from a pinned, checksum-verified commit that fixes it. The coverage report no longer counts lines bash never traces: empty case branches, closing fi/esac/done/} lines and array continuations. New tests cover limit-reset sign-in and HTTP errors, Hermes and pi aggregation failures, OpenCode and local analytics errors, quota-alert icons, history export destinations, 9Router's SQLite ledger, package refusals, qmlls-setup and the remaining provider status branches. The files below 80% are now at 100%. development-gates.md drops a stray merge marker. Signed-off-by: Bernardo Pinto Gomes <bernardopgomes@hotmail.com>
The README prose rounds the provider count down to a multiple of ten, so it changes only at the next ten; the badge keeps the exact count. Provider examples follow the coverage matrix (Cursor reports quota, Amp is informational), the docs section points at the 2.1 notes and links the development gates. TODO and roadmap record the 95% gate and the pinned kcov build. Signed-off-by: Bernardo Pinto Gomes <bernardopgomes@hotmail.com>
github-actions
Bot
added
documentation
shellcheck -S warning flags a bare VAR= prefix (SC1007). Signed-off-by: Bernardo Pinto Gomes <bernardopgomes@hotmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three changes, one commit each.
fix(dash): the DMS registry review bot flagged the DankDash card's hardcoded bar height, radius and spacing (duxlabs-dev/dux-plugin-registry#1095). The bars now use
Theme.spacingS,height / 2andTheme.spacingXS, like the DMS example cards. The new runtime check also exposed an older bug: the row count ignored the card's content padding, so the last row ran into the bottom edge. Rows are now fitted into the content area. The check fails on the previous card and on a shrunken row height.test(coverage): total statement coverage goes from 90.1% to 97.9%, and the CI gate goes from 80% to 95%.
KCOV_COMMIT/KCOV_SHA256) that fixes it.scripts/coverage-reportno longer counts lines bash never traces (200) ;;,fi ;;,} >file, array continuations).get-hermes-analytics,native/hermes.bash,reset-provider-limits,native/opencode.bash,get-local-analytics,send-quota-alert,export-usage-history,get-usage-historyandnative/9router.bash.scripts/package-releaseis at 95.7%.test-package-release.shandtest-qmlls-setup.sh.docs:
scripts/render-badgesrounds the count down to a multiple of ten, and the badge stays exact.Checked locally: every shell suite with provider keys unset, the QML runtime suite,
scripts/check-metadata,actionlint, andscripts/coveragewith the pinned kcov (97.92%, gate 95%).