Skip to content

fix: collect semantic evidence across declared paths - #31

Merged
bewaterhere-coder merged 4 commits into
mainfrom
fix/semantic-multi-path-evidence
Nov 1, 2026
Merged

bewaterhere-coder merged 4 commits into
mainfrom
fix/semantic-multi-path-evidence

Conversation

@bewaterhere-coder

Copy link
Copy Markdown
Owner

Summary

  • Scan every declared source path for a Semantic Rule instead of returning after the first existing file.
  • Aggregate token evidence across the bounded source set; a token found in any declared readable file is recorded.
  • Keep not_evaluated when no declared source can be read.
  • Add regression tests for evidence split across files and for a later file being ignored after an earlier file exists.

Why

semantic_rules[].paths accepts multiple paths, but the evaluator previously returned after the first existing readable file. Tokens located in later declared files were ignored, causing false review_needed results and incomplete evidence.

Boundaries

  • The scan remains bounded by the existing per-file size limit and declared path list.
  • Comment filtering remains conservative and is not a language parser.
  • pattern_observed_control_flow_unverified still does not prove control-flow or runtime correctness.
  • No API or schema version change; no new gate.

Validation

Python 3.10–3.13, MCP stdio E2E and Sample Project Advisory.

@bewaterhere-coder
bewaterhere-coder merged commit c8d2147 into main Nov 1, 2026
6 checks passed
@bewaterhere-coder
bewaterhere-coder deleted the fix/semantic-multi-path-evidence branch November 1, 2026 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant