Skip to content

fix: preserve semantic evidence after comment markers in strings - #33

Merged
bewaterhere-coder merged 2 commits into
mainfrom
fix/string-aware-semantic-comments
Nov 1, 2026
Merged

bewaterhere-coder merged 2 commits into
mainfrom
fix/string-aware-semantic-comments

Conversation

@bewaterhere-coder

Copy link
Copy Markdown
Owner

Summary

  • Make C# and Lua comment filtering aware of quoted strings and Lua long-bracket strings.
  • Preserve source text inside strings while masking actual line/block comments.
  • Add regression tests for https:// in C# strings and -- in Lua strings so later code on the same line remains visible.

Why

The previous comment-removal regex treated // and -- inside string literals as comment starts. This could erase real code evidence later on the same line and produce false review_needed results.

Boundaries

  • This remains a bounded literal scan, not a full C# or Lua parser.
  • No claim of control-flow or runtime correctness is added.
  • Existing non-blocking advisory semantics are unchanged.
  • No public API or schema version change.

Validation

Python 3.10–3.13, MCP stdio E2E and Sample Project Advisory.

@bewaterhere-coder
bewaterhere-coder merged commit ac45596 into main Nov 1, 2026
6 checks passed
@bewaterhere-coder
bewaterhere-coder deleted the fix/string-aware-semantic-comments branch November 1, 2026 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant