Skip to content

fix: run selected plugin guidance independently of discovery - #36

Merged
bewaterhere-coder merged 4 commits into
mainfrom
fix/explicit-plugin-guidance-independent-discovery
Nov 1, 2026
Merged

bewaterhere-coder merged 4 commits into
mainfrom
fix/explicit-plugin-guidance-independent-discovery

Conversation

@bewaterhere-coder

Copy link
Copy Markdown
Owner

Summary

  • Activate professional guidance from valid, explicitly selected Profile plugins, not from automatic discovery results.
  • Keep discovery limited to candidate suggestions and preview-only advisory output.
  • Add a regression test where Unity is explicitly selected and Unity source exists, but the normal Unity discovery marker is absent.
  • Update the Chinese and English README and best-practices guide.

Why

The Core previously built professional_guidance by filtering discovered plugins against the selected set. An explicitly selected plugin therefore produced no professional guidance when its detection marker was absent. This conflated discovery with activation and made an explicit Profile selection ineffective for source-only or nonstandard project layouts.

Expected behavior

  • Discovery suggests plugins; it does not activate them.
  • Explicit Profile selection activates that plugin's professional guidance independently of detection markers.
  • If no matching source evidence is found, the result remains not_evaluated.
  • Unselected plugins remain inactive.
  • All findings remain advisory and non-blocking.

Scope

Core selection semantics, regression test and bilingual documentation only. No plugin manifests or public API changes.

Validation

GitHub Actions: Python 3.10–3.13, MCP stdio E2E and Sample Project Advisory.

@bewaterhere-coder
bewaterhere-coder merged commit 7c4b67c into main Nov 1, 2026
6 checks passed
@bewaterhere-coder
bewaterhere-coder deleted the fix/explicit-plugin-guidance-independent-discovery branch November 1, 2026 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant