Repository navigation
fix: align plugin manifest schema with runtime validation - #37
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
..traversal segments, backslashes and NUL characters, matching the runtime path validator.professional_guidancefields in runtime validation and JSON Schema.Why
The published JSON Schema accepted paths such as
../outside,a/../band backslash paths even though the runtime rejected them. Contributors relying on the Schema could therefore publish manifests that fail at load time. The runtime and Schema also accepted whitespace-only guidance fields, allowing meaningless IDs and signals. The English docs additionally contradicted the current explicit-selection behavior.Boundaries
Validation
Python 3.10–3.13, manifest schema/runtime parity tests, MCP stdio E2E and Sample Project Advisory.