Skip to content

test: remove duplicate plugin extension regression methods #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bewaterhere-coder merged 3 commits into from
Nov 1, 2026
Merged

test: remove duplicate plugin extension regression methods #40

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c2f4185
test: deduplicate plugin extension regression cases
bewaterhere-coder Nov 1, 2026
23e98f7
test: isolate path rejection cases and remove nested duplicate
bewaterhere-coder Nov 1, 2026
2d83b7c
test: remove stray fragment after symlink regression
bewaterhere-coder Nov 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 4 additions & 48 deletions tests/test_plugin_extension.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,13 +52,13 @@ def test_manifest_paths_reject_windows_backslash_traversal(self):
with self.assertRaisesRegex(ValueError, 'Invalid plugin detection'):
manifests(self.plugins)

def test_manifest_paths_reject_nul_character(self):
self.add('nul-path', {'id': 'nul-path', 'version': '1.0.0', 'domain': 'code', 'standards': ['architecture'], 'detection': [['bad\x00path']]})
def test_manifest_paths_reject_windows_drive_prefix(self):
self.add('drive-path', {'id': 'drive-path', 'version': '1.0.0', 'domain': 'code', 'standards': ['architecture'], 'detection': [['C:/outside/project']]})
with self.assertRaisesRegex(ValueError, 'Invalid plugin detection'):
manifests(self.plugins)

def test_manifest_paths_reject_windows_drive_prefix(self):
self.add('drive-path', {'id': 'drive-path', 'version': '1.0.0', 'domain': 'code', 'standards': ['architecture'], 'detection': [['C:/outside/project']]})
def test_manifest_paths_reject_nul_character(self):
self.add('nul-path', {'id': 'nul-path', 'version': '1.0.0', 'domain': 'code', 'standards': ['architecture'], 'detection': [['bad\x00path']]})
with self.assertRaisesRegex(ValueError, 'Invalid plugin detection'):
manifests(self.plugins)

Expand Down Expand Up @@ -133,47 +133,3 @@ def test_symlink_outside_project_not_detected(self):
self.assertNotIn('custom', [p['plugin_id'] for p in inspect(self.root, self.plugins)['suggested_plugins']])
finally:
outside.unlink()
self.add('drive-path', {'id': 'drive-path', 'version': '1.0.0', 'domain': 'code', 'standards': ['architecture'], 'detection': [['C:/outside/project']]})
with self.assertRaisesRegex(ValueError, 'Invalid plugin detection'):
manifests(self.plugins)

def test_manifest_sources_validate_required_fields_and_date(self):
self.add('bad-source', {'id': 'bad-source', 'version': '1.0.0', 'domain': 'code', 'standards': ['architecture'], 'detection': [['custom.project']], 'sources': [{'publisher': 'Example', 'title': 'Guide', 'url': 'https://example.com', 'engine_versions': '1.x', 'accessed': 'not-a-date'}]})
with self.assertRaisesRegex(ValueError, 'Invalid plugin source date'):
manifests(self.plugins)

def test_bad_manifest_rejected(self):
self.add('broken', {'id': 'broken', 'version':'1.0.0', 'domain':'code', 'standards':'not-a-list', 'detection':[]})
with self.assertRaisesRegex(ValueError, 'Invalid plugin manifest'):
manifests(self.plugins)

def test_nonexistent_extension_dir_rejected(self):
with self.assertRaisesRegex(ValueError, 'Plugin directory missing'):
manifests(self.root / 'missing')

def test_project_not_mutated(self):
self.add()
prior = sorted(p.relative_to(self.root).as_posix() for p in self.root.rglob('*') if p.is_file())
inspect(self.root, self.plugins)
after = sorted(p.relative_to(self.root).as_posix() for p in self.root.rglob('*') if p.is_file())
self.assertEqual(prior, after)

def test_escape_marker_rejected(self):
self.add('escape', {'id':'escape','version':'1.0.0','domain':'code','standards':['architecture'],'detection':[['../outside']]})
with self.assertRaisesRegex(ValueError, 'Invalid plugin'):
manifests(self.plugins)

def test_absolute_marker_rejected(self):
self.add('absolute', {'id':'absolute','version':'1.0.0','domain':'code','standards':['architecture'],'detection':[['/etc/passwd']]})
with self.assertRaisesRegex(ValueError, 'Invalid plugin'):
manifests(self.plugins)

def test_symlink_outside_project_not_detected(self):
outside = self.root.parent / ('frameforge-outside-' + self.root.name)
outside.write_text('x')
try:
(self.root/'custom.project').symlink_to(outside)
self.add()
self.assertNotIn('custom', [p['plugin_id'] for p in inspect(self.root, self.plugins)['suggested_plugins']])
finally:
outside.unlink()
Loading