iOS: consolidate SHA-256 hashing into a shared utility - #47
Open
ofalvai wants to merge 1 commit into
Open
Conversation
ofalvai
changed the title
ofalvai
force-pushed
the
ios-sha256-refactor
branch
from
August 28, 2026 14:20
0a49aa1 to
d648e54
Compare
There was a problem hiding this comment.
Pull request overview
Consolidates iOS SHA-256 hashing into a reusable utility and reduces memory usage through chunked file reads.
Changes:
- Adds shared data and file hashing functions.
- Migrates update-manifest hashing to the utility.
- Propagates file-hashing failures through existing error paths.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
ios/CodePush/CodePushUpdateUtils.m |
Uses shared hashing functions and handles failures. |
ios/CodePush/CodePushSha256.m |
Implements SHA-256 hashing for data and streamed files. |
ios/CodePush/CodePushSha256.h |
Declares the shared hashing interface. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
ofalvai
force-pushed
the
ios-sha256-refactor
branch
from
August 28, 2026 14:44
d648e54 to
eb3db6c
Compare
ofalvai
force-pushed
the
ios-sha256-refactor
branch
from
August 31, 2026 12:09
eb3db6c to
5b1c56d
Compare
ofalvai
force-pushed
the
ios-sha256-refactor
branch
from
September 3, 2026 10:48
5b1c56d to
35dfdb1
Compare
ofalvai
force-pushed
the
ios-sha256-refactor
branch
2 times, most recently
from
September 8, 2026 10:50
6dd99d3 to
bb07518
Compare
ofalvai
commented
Sep 8, 2026
| + (void)addFileToManifest:(NSURL *)fileURL | ||
| + (BOOL)addFileToManifest:(NSURL *)fileURL | ||
| manifest:(NSMutableArray *)manifest | ||
| error:(NSError **)error |
Collaborator
Author
There was a problem hiding this comment.
File reading errors were previously unhandled, that's why the signature is changing (standard ObjC error handling pattern).
ofalvai
marked this pull request as ready for review
September 8, 2026 11:00
ofalvai
force-pushed
the
ios-sha256-refactor
branch
from
September 9, 2026 06:36
bb07518 to
a327bf7
Compare
ofalvai
removed this pull request from stack #41
September 9, 2026 06:38
ofalvai
added this pull request to stack #57
September 9, 2026 06:42
ofalvai
force-pushed
the
ios-sha256-refactor
branch
from
September 9, 2026 09:57
a327bf7 to
f5062ad
Compare
ofalvai
force-pushed
the
ios-sha256-refactor
branch
from
September 9, 2026 10:34
f5062ad to
1002f17
Compare
There was a problem hiding this comment.
🟡 Changes recommended
The tvOS target omits the new implementation and will fail to link.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
- Files reviewed: 6/6 changed files
- Comments generated: 2
- Review effort level: Balanced
| CC_SHA256_CTX context; | ||
| CC_SHA256_Init(&context); | ||
|
|
||
| static const NSUInteger kChunkSize = 1024 * 8; |
Collaborator
Author
There was a problem hiding this comment.
ofalvai
force-pushed
the
ios-sha256-refactor
branch
from
September 9, 2026 11:25
1002f17 to
11e4e4d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split off from #48, I didn't want to bloat that PR with unrelated changes. We'll be doing additional SHA-256 checksumming in new codepaths, let's extract hashing code to a common utility.
As a bonus, existing callers which loaded entire files into memory are now loading data in smaller chunks.