Repository navigation
Conversation
hud_expansion_opaque already fixed the DMA transfer size but didn't remove the BG2 backup/restore routine (which is only there because of the vanilla transfer size being too large) Interestingly the hudfix copies 112 tiles over ($0E00) vs what should be correct vanilla 128 tiles ($1000), with a note in the .asm saying to not get bottom row of screen. I assume this was / is for some graphical corruption? I tried it with both and couldn't see any differences but left the vanilla_hudfix patch to the DMA transfer size in place and just removed the unnecessary backup/restore of the bg2 tiles on pause/unpause.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hud_expansion_opaque already fixed the DMA transfer size but didn't remove the BG2 backup/restore routine (which is only there because of the vanilla transfer size being too large and overwriting the BG2 tilemap.)
Interestingly the hudfix copies 112 tiles over ($0E00) vs what should be 'correct' vanilla 128 tiles ($1000), with a note in the .asm saying to not get bottom row of screen?
I assume this was / is for some graphical corruption? I tried it with both and couldn't see any differences but left the vanilla_hudfix patch to the DMA transfer size in place and just removed the unnecessary backup/restore of the bg2 tiles on pause/unpause.