Repository navigation
Pin returned MCP tool errors against max_tool_failures - #35
Merged
arjunvlama merged 1 commit intoSep 13, 2026
Merged
Conversation
The existing e2e test only covered on_failure: fail. The other half of boundflow#7 — tool_failure_counts staying empty and the failure breaker never firing — was unpinned, and the MCP client still described the bug as live.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Error executing tool …/status=error, counts it, and still hands the text to the model). This PR does not redo that.always_fails(raise → adapter returns a string, noon_failure: fail) incrementstool_failure_countsand tripsmax_tool_failures. The old wrapper would have let the task finish. The existing test only coverson_failure: fail.charter/mcp/client.pyand the matching comment intest_mcp_live.pyso they stop saying the bug is still live.Closes #7.
Test plan
pytest(unit)pytest tests/e2e/test_failures.py::test_a_returned_mcp_error_trips_the_failure_breakerpytest tests/e2e(full suite, twice)