Close every reply with an invitation to contact support - #31
Merged
Merged
Conversation
A sender whose report did not come out had no way to know where to turn, and one whose report did had no easy way to suggest an improvement. Every reply now ends with: Questions, problems, or suggestions? Your feedback is welcome at <address>. The address is the new support_address key in email.yaml, not the code, since it is deployment-specific. Empty or absent leaves the line off, so a reply is unchanged until it is configured; an address with no "@" fails at load, as alert_recipient does. The line is added once, in deliver, after the attach-or-link branch, so it closes attachment replies and link replies alike, successes and failures, and comes after the links. Operator alerts go out through SendAlert and do not get it. It is set off by a blank line rather than the "-- " signature delimiter, which many mail clients dim or fold. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Every reply to a sender now ends with:
support_addresskey inconfig/email.yaml, which keeps the deployment's domain out of the public code. Empty or absent leaves the line off, so replies are unchanged until it's set. An address with no@fails at load, matchingalert_recipient.deliver, after the attach-or-link branch, so it closes attachment and Sheets-link replies, for successful and failed jobs, and comes after the links.SendAlert.--signature separator, because many mail clients dim or fold what follows it.Test plan
internal/mailgun/support_test.gocovers:SendAlertdoesn't include it@)delivermakes the three delivery tests failgo test ./...,go vet ./...,gofmt -lclean🤖 Generated with Claude Code