Repository navigation
revert: keep release/2.0 on stable Dart; augmentations continue on release/2.0-augmentations - #227
Conversation
This reverts commit da560a0. release/2.0 stays on stable Dart (SDK floor >=3.11.0) so stable-Dart consumers can use 2.0.0-alpha.1. The augmentations work continues on release/2.0-augmentations until Dart 3.14 is stable. Claude-Session: https://claude.ai/code/session_012Enp61FP6np18JLtz1ZaqK
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 62b7c38442
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ## Requirements | ||
|
|
||
| - Dart SDK: `>=3.14.0-315.1.beta <4.0.0` for `ack` and `ack_generator` | ||
| - Dart SDK: `>=3.9.0 <4.0.0` for `ack` and `ack_generator` |
There was a problem hiding this comment.
This restored requirement promises support for Dart 3.9, but both packages/ack/pubspec.yaml and packages/ack_generator/pubspec.yaml now declare >=3.11.0; consequently, a user following this installation guide on Dart 3.9 cannot resolve either package. Update the restored compatibility documentation to the actual 3.11 floor, including the other reverted 3.9/Flutter 3.35 references.
Useful? React with 👍 / 👎.
| @Validate.minLength(2) required final String displayName, | ||
| @Validate.email() required final String email, | ||
| final String role = 'member', | ||
| }); | ||
| }) with _$ProfileAck { |
There was a problem hiding this comment.
On the restored Dart 3.13.4 toolchain, this primary-constructor syntax is still experimental—the repository's own class_model_emitter_test.dart enables primary-constructors specifically for its Dart 3.13 fixture—but the documented generation command is now just dart run build_runner build. Users copying this example therefore fail before generation; use a conventional constructor in the default guide or document and pass the required analyzer/build experiment flags.
Useful? React with 👍 / 👎.
Summary
Reverts #225 (da560a0, "refactor!: migrate Ack 2.0 to Dart 3.14 augmentations") from
release/2.0.release/2.0stays on stable Dart (SDK floor>=3.11.0, Flutter 3.47.5 in.fvmrc) so stable-Dart consumers can use 2.0.0-alpha.1. #225 moved the floor to a Dart 3.14 beta with experiment flags. The augmentations work is preserved unchanged onrelease/2.0-augmentations(at da560a0) and continues there until Dart 3.14 is stable.The resulting tree is identical to 7aef299, the last
release/2.0commit before #225:git diff 7aef299 HEAD --statis empty.Validation
Run locally on Dart 3.13.4 stable (Flutter 3.47.5 via fvm):
git diff 7aef299 HEAD --stat: emptydart pub get: resolveddart scripts/verify_release_tag.dart v2.0.0-alpha.1 --skip-ancestry:v2.0.0-alpha.1 is releasable.dart scripts/api_check.dart 1.7.0: completed for all five packages (exit 0)dart scripts/publish_dry_run.dart:All 5 packages publish cleanly.(0 warnings each)The full test suite was not run locally; CI covers it.
https://claude.ai/code/session_012Enp61FP6np18JLtz1ZaqK