Add kernel update to Terraform - #4
Open
pegahnikbakht wants to merge 4 commits into
Open
pegahnikbakht wants to merge 4 commits into
pegahnikbakht wants to merge 4 commits into
Conversation
antoniacobaeus
left a comment
antoniacobaeus
left a comment
Contributor
There was a problem hiding this comment.
Looks good in general, just a few questions, see comments.
Would it be suitable to gate this feature behind a variable, or should we enforce it always?
| inline = [ | ||
| "cloud-init status --wait", | ||
| "sudo env DEBIAN_FRONTEND=noninteractive apt-get update", | ||
| "sudo env DEBIAN_FRONTEND=noninteractive apt-get install --yes --install-recommends linux-generic", |
Contributor
There was a problem hiding this comment.
Does this work on non-debian/ubuntu cloud images? Such as RHEL?
I am not sure what we usually use on CSPs
| @@ -0,0 +1,23 @@ | |||
| resource "null_resource" "update_kernel" { | |||
| depends_on = [aws_instance.cvm] | |||
Contributor
There was a problem hiding this comment.
I think this makes it run after the server has been provisioned? and attested?
With the kernel update I believe the measurement would change and thus the first attestation isn't really valid for this enclave then. An attestation after the kernel update would be more accurate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.