Repository navigation
Release v3.0.0-alpha.6: piped-key fix and changelog cut - #300
Merged
Merged
Conversation
The early key check read the key file and dropped the signer, and signer creation read it again after the chain check. A source that yields its contents once, such as --auth-private-key-file /dev/stdin, was empty the second time and refused as an invalid key (exit 30). The signer is now prepared once from local sources before the network, the KMS key-id file included, and the wallet is built from what was read.
Titles the Unreleased section with the tag and lists the generation's addresses: the five Dave and PRT contracts that moved, and the rollups contracts that keep v3.0.0-alpha.5's. They match the deployment-addresses asset CI built for main. The cut's to-do item goes, and the audit plan marks the release candidate done.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cuts v3.0.0-alpha.6, the release candidate for the staging pipeline and testnet, with one fix found in a last review. Two commits:
--auth-private-key-file /dev/stdin, was empty the second time and refused as an invalid key (exit 30).SignerSource::preparenow reads every local source once before the network, the KMS key-id file included, andinto_walletbuilds the wallet from what was read. Validation still happens before any network call. The bug never shipped, so it gets no changelog entry.The addresses are what the deploy scripts produce. They match the
deployment-addressesasset that CI built for main (all 18 contracts on both chains), and against v3.0.0-alpha.5's asset exactly five move: the provider, the factory,DaveAppFactory,CartesiStateTransitionandTournament. The rollups contracts keep their addresses.Validation
prepare, and checks the wallet's address./dev/stdinexits 30 with "does not hold a valid private key". After it, stdin and a file both pass the signer and stop at the next check.just check; the anvil harness (28).After merge
Tag
v3.0.0-alpha.6on main and create its GitHub pre-release; the tag's CI uploads the node binaries, contract artifacts, deployment addresses and devnet.