Repository navigation
fix: address Dave QA report findings - #303
Open
stephenctw wants to merge 8 commits into
Open
stephenctw wants to merge 8 commits into
stephenctw wants to merge 8 commits into
Conversation
stephenctw
force-pushed
the
fix/qa-report-findings
branch
from
October 20, 2026 13:07
4dc351d to
7419c8c
Compare
Member
Author
|
@jplgarcia I can't add you as a reviewer, but your feedback is very valuable to us. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The QA report identified Dave paths that stop honest dispute defense or leave deployment and epoch boundaries unsafe. This PR contains changes to the Dave repository only.
Validation: after rebasing onto main, 326 node unit tests and the three focused foreclosure, terminal-guest and nonstandard-yield integration tests passed. Before rebasing, the full
just checkgate and 30 node integration scenarios passed, and additional real-contract regressions cover nonstandard yields and a restarted halted guest defeating a malicious commitment through a leaf proof. The new contract bytecode requires new deployments and changes predicted addresses. Existing contracts are not migrated by this PR. Finding dispositions are recorded indocs/reviews/2026-10-20-sling-qa/closure.json.Cross-project changes required
These findings are not fully resolved by this PR. No reference-node implementation or patch is included.
The RPC model remains one consistent trusted node; no provider fallback was added. Gas estimation cannot eliminate inclusion races. The report's 403 ETH estimate is not a security bound; the input ceiling is enforced structurally.