Repository navigation
[FEAT] IncrementalAdditive Cleanup for Chapter 16 Part 1 - #1419
henrydingliu wants to merge 11 commits into
Conversation
Pyright Type CompletenessView the full Project (full
Other symbols referenced but not exported by
Symbols without documentation:
Patch (exported symbols added or changed by this PR): 33.3% fully typed (2 / 6); 1 no longer exported
Patch symbol details
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1419 +/- ##
==========================================
+ Coverage 91.79% 92.74% +0.95%
==========================================
Files 96 102 +6
Lines 5494 5967 +473
Branches 707 742 +35
==========================================
+ Hits 5043 5534 +491
+ Misses 327 312 -15
+ Partials 124 121 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 1eae41e. Configure here.
|
@genedan just assigned this to you as i'd like this to land so i can continue working on chapter 16. |

Summary of Changes
More clean-up and bug fix as I work through Chapter 16
zeta_-related properties into IncrementalMixin, matching DisposalMixincum_to_incrforcum_zeta_, w/ new test to guard future drift; also improved readability of the surrounding code_param_propertyacross modules to condense the universal properties toDevelopmentBaseand keep module-specific properties at module levelRelated GitHub Issue(s)
#588
#377
AI/LLM Usage
AI did some autofill of docstrings, which I then validated edited
Additional Context for Reviewers
zeta_ still shows the wrong development labels. will address after #1304
Submitter's Checklist
[FIX],[FEAT],[DOCS],[TST],[CHORE], or[BRK]).Reviewer's Checklist
Note
Medium Risk
Touches core triangle cum/incr logic and how fitted parameters are stored and exposed; behavior changes for additive patterns are guarded by new tests but affect development workflows.
Overview
Introduces
IncrementalMixin(mirroringDisposalMixin) sozeta_/cum_zeta_live on triangles and estimators with backing_zeta_, enforced pattern flags on set, andhas_zetakeyed off_zeta_.cum_zeta_is removed fromcommonin favor of the mixin.incr_to_cum/cum_to_incronTriangleare refactored to branch explicitly onis_pattern,is_additive, andis_disposal_rate, fixing incorrect incremental conversion for additivezeta_/cum_zeta_(newis_additiveproperty).DevelopmentBase._param_propertyonly applies shared wrapping;Development,IncrementalAdditive, and disposal each override for module-specific values and flags.Tests cover
cum_zeta_assignment and missing-zeta_errors.Reviewed by Cursor Bugbot for commit d461b14. Bugbot is set up for automated code reviews on this repo. Configure here.