[DEPR] Deprecation warning for inplace=True - #1468
henrydingliu wants to merge 8 commits into
Conversation
Pyright Type CompletenessView the full Project (full
Other symbols referenced but not exported by
Symbols without documentation:
Patch (exported symbols added or changed by this PR): 100.0% fully typed (1 / 1)
Patch symbol details
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 27082d9. Configure here.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1468 +/- ##
=======================================
Coverage 94.14% 94.14%
=======================================
Files 96 96
Lines 5843 5843
Branches 739 739
=======================================
Hits 5501 5501
Misses 221 221
Partials 121 121
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|

Summary of Changes
Related GitHub Issue(s)
AI/LLM Usage
Additional Context for Reviewers
Submitter's Checklist
[FIX],[FEAT],[DOCS],[TST],[CHORE], or[BRK]).Reviewer's Checklist
Note
Low Risk
Documentation and type hints only; no change to conversion logic or inplace return behavior yet.
Overview
Documents an upcoming API alignment for
Triangle.incr_to_cumandTriangle.cum_to_incr: wheninplace=True, returningselfis deprecated as of 0.11 and 2.0 is expected to returnNone(pandas-style inplace).incr_to_cumalso gets explicit typing (inplace: bool = False, return typeSelf) and importsSelffromtyping. Runtime behavior is unchanged—both methods still mutate and returnselfwheninplace=True.Reviewed by Cursor Bugbot for commit c070945. Bugbot is set up for automated code reviews on this repo. Configure here.