Skip to content

Fix handling of map components parsing for CellML 1.X models - #1502

Open
hsorby wants to merge 4 commits into
cellml:mainfrom
hsorby:1501-map_components
Open

hsorby wants to merge 4 commits into
cellml:mainfrom
hsorby:1501-map_components

Conversation

@hsorby

@hsorby hsorby commented Oct 13, 2026

Copy link
Copy Markdown
Contributor

@hsorby hsorby added the Bug label Oct 13, 2026
@agarny

agarny commented Oct 13, 2026

Copy link
Copy Markdown
Contributor

Is this ready to review?

@hsorby

hsorby commented Oct 13, 2026

Copy link
Copy Markdown
Contributor Author

Is this ready to review?

Yes, but it includes follow on work from #1500.

@hsorby
hsorby requested a review from agarny October 13, 2026 05:52
agarny
agarny previously approved these changes Oct 13, 2026

@agarny agarny left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

jmdowrick
jmdowrick previously approved these changes Oct 15, 2026
@hsorby
hsorby dismissed stale reviews from jmdowrick and agarny October 15, 2026 06:23

The merge-base changed after approval.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CellML 1.0/1.1 map_components component attributes are order dependent

3 participants