Repository navigation
fix(security): replace shell interpolation with execFileSync and bound --brand path - #418
Merged
ch-bas merged 2 commits intoOct 22, 2026
Merged
Conversation
Owner
|
Merged — thanks @Terrib1e for the careful report and the clean fix. Verified locally that the build output is unchanged and the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR resolves two build/ingest script security weaknesses identified during a defensive audit (
Elijah Clark/@Terrib1e):1. Shell Command Interpolation (
CWE-78) inscripts/build.jsandscripts/strix-fetch.jsaddedDateFollow(file)inscripts/build.jspassed double-quoted string interpolation (execSync(\git log --follow --diff-filter=A --format=%ad --date=short -- "${file}"`)) to/bin/shduringpull_requestCI (build.ymlruns withpermissions: contents: write`).fetchDb()anddumpStreams()inscripts/strix-fetch.jsinterpolatedDB_URL(STRIX_DB_URL/STRIX_SLUG/STRIX_DB) anddbPathinto/bin/shcommand strings viaexecSync.execSyncshell strings withexecFileSyncargument arrays (matching the pattern already used inscripts/package-release.js) and sanitizedDB_NAMEwithpath.basename().2. Unbounded
--brandPath Resolution (CWE-22) inscripts/archive-sources.jscamerasFromArgs()resolved--brand <arg>(reachable viaworkflow_dispatch.inputs.scopeinarchive-sources.yml) usingpath.join("cameras", args[brandIdx + 1])without verifying that the resolved directory remains insidecameras/.path.resolvecontainment check ensuring the target directory is a strict child ofcameras/.