Repository navigation
Fix the CI type check (mypy) and get_etrace_of on element-wise weights - #193
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the failing
typecheck_and_buildCI job. Onmain,python -m mypy braintracereported 36 errors in 10 files. It is nowSuccess: no issues found in 63 source files.Cause
The newer JAX stubs type:
Var.avalas the abstract baseAbstractValue(noshape/dtype/ndim);eqn.invars/jaxpr.outvarsaslist[Var | Literal];Var(...)with one argument.Also, the
FlattedDict.splitstub promises aNestedDict.Fix (type-only, apart from one bug)
_compatible_imports.shaped_aval(atom): a typed accessor (acasttoShapedArray). It is used at every flagged.aval.shape/.dtype/.ndimsite.find_matched_vars/find_element_exist_in_the_setacceptVar | Literal(they already filtered withisinstance).hid_param_op: trainable invars areVar | Literal. A literal never traces to aParamState, and the loop narrows on that.Vars);FlattedDict.split.new_var:# type: ignore[call-arg]on the pre-0.6.2 branch only.Bug found on the way
IODimVjpAlgorithm.get_etrace_ofcheckedetrace_x_key(relation.x_var) is not None. That value isid(x_var), neverNone. So for an element-wise relation (x_var is None), it looked upid(None)and raisedKeyError. It now checksrelation.x_var.io_dim_vjp_test.py::TestStateLifecycle::test_get_etrace_of_elementwise_weightreproduces it: it fails withKeyErrorbefore the fix and passes after.Verification
python -m mypy braintrace: no issues.Spec:
docs/specs/2026-10-24-mypy-typecheck.md.