Skip to content

fix: preserve TLS verification context across retries - #135

Open
Shubham-Padkonde wants to merge 1 commit into
chargebee:masterfrom
Shubham-Padkonde:fix/preserve-tls-context-on-retry
Open

Shubham-Padkonde wants to merge 1 commit into
chargebee:masterfrom
Shubham-Padkonde:fix/preserve-tls-context-on-retry

Conversation

@Shubham-Padkonde

Copy link
Copy Markdown

Description

_make_request() and its async counterpart remove verify from the shared request_args dictionary. A retried request therefore creates its HTTPX client with verify=True instead of reusing the original SSLContext, losing the configured certificate trust store.

Copy the request arguments before separating the client-only verify option. Both retries retain the same SSLContext; verify still does not reach client.request().

Related Issues

Found during retry-path review; independent of the rate-limit changes in #134.

Additional Information

The sync and async regression cases fail before the change. All 60 unittest tests pass afterward, including a 503-to-200 retry that checks both client constructors receive the original context. git diff --check passes.

@coderabbitai

coderabbitai Bot commented Oct 2, 2026

Copy link
Copy Markdown

Warning

Review limit reached

This review ran on the open-source allowance, not this organization's plan, because the pull request author doesn't have an assigned seat. Waiting won't change this — ask an organization admin to assign them a seat, or add seats in Billing if every seat is already assigned, then retry.

Next included review available in 57 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 482f8bf8-8306-49f9-af8d-62578732a11b

📥 Commits

Reviewing files that changed from the base of the PR and between f1fbfde and 9a32e1c.

📒 Files selected for processing (2)
  • chargebee/http_request.py
  • tests/test_http_request.py
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Comment @coderabbitai help to get the list of available commands.

@snyk-io

snyk-io Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

✅ Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
✅ Open Source Security 0 0 0 0 0 issues
✅ Licenses 0 0 0 0 0 issues
✅ Code Security 0 0 0 0 0 issues
✅ Secrets 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant