Repository navigation
fix: preserve TLS verification context across retries - #135
Shubham-Padkonde wants to merge 1 commit into
Conversation
|
Warning Review limit reachedThis review ran on the open-source allowance, not this organization's plan, because the pull request author doesn't have an assigned seat. Waiting won't change this — ask an organization admin to assign them a seat, or add seats in Billing if every seat is already assigned, then retry. Next included review available in 57 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Comment |
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Description
_make_request() and its async counterpart remove verify from the shared request_args dictionary. A retried request therefore creates its HTTPX client with verify=True instead of reusing the original SSLContext, losing the configured certificate trust store.
Copy the request arguments before separating the client-only verify option. Both retries retain the same SSLContext; verify still does not reach client.request().
Related Issues
Found during retry-path review; independent of the rate-limit changes in #134.
Additional Information
The sync and async regression cases fail before the change. All 60 unittest tests pass afterward, including a 503-to-200 retry that checks both client constructors receive the original context. git diff --check passes.