Repository navigation
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing (5)
Comment |
Contributor
Test coverage✅ Gate passed — all 77 files are at or above the 95% floor.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing Windows installation smoke test sets CI=1 and skips interactive onboarding. Add a ConPTY test using the released 1.4.0 executable under Windows PowerShell 5.1 and PowerShell 7.
The test runs this checkout's unchanged installer with
irm ... | iex, downloads and verifies the release, answers Yes/No/Enter through the terminal, and checks consent, global skill locations, alias setup, and completion within a deadline. All writes use temporary directories.Initial run deliberately leaves install.ps1 unchanged to establish the current behavior before fixing any confirmed failures.
Validation: Python syntax, TypeScript typecheck, and 40 installer/workflow tests passed locally. Windows execution runs in the new required CI jobs.
Adds a Windows ConPTY integration test for the released installer in PowerShell 5.1 and 7. The test checks Yes, No, and Enter responses, installation results, and aliases. CI now requires this test. After consent,
install.ps1installs skills globally and prints the global-install command when consent is declined or onboarding is non-interactive.