Skip to content

test: verify Windows installer prompts in a real terminal - #9

Closed
cb-logesh wants to merge 3 commits into
mainfrom
test/windows-installer-terminal
Closed

cb-logesh wants to merge 3 commits into
mainfrom
test/windows-installer-terminal

Conversation

@cb-logesh

@cb-logesh cb-logesh commented Oct 5, 2026 •

Copy link
Copy Markdown
Collaborator

The existing Windows installation smoke test sets CI=1 and skips interactive onboarding. Add a ConPTY test using the released 1.4.0 executable under Windows PowerShell 5.1 and PowerShell 7.

The test runs this checkout's unchanged installer with irm ... | iex, downloads and verifies the release, answers Yes/No/Enter through the terminal, and checks consent, global skill locations, alias setup, and completion within a deadline. All writes use temporary directories.

Initial run deliberately leaves install.ps1 unchanged to establish the current behavior before fixing any confirmed failures.

Validation: Python syntax, TypeScript typecheck, and 40 installer/workflow tests passed locally. Windows execution runs in the new required CI jobs.

Adds a Windows ConPTY integration test for the released installer in PowerShell 5.1 and 7. The test checks Yes, No, and Enter responses, installation results, and aliases. CI now requires this test. After consent, install.ps1 installs skills globally and prints the global-install command when consent is declined or onboarding is non-interactive.

@snyk-io

snyk-io Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

✅ Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
✅ Open Source Security 0 0 0 0 0 issues
✅ Licenses 0 0 0 0 0 issues
✅ Code Security 0 0 0 0 0 issues
✅ Secrets 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@coderabbitai

coderabbitai Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Enterprise
  • Run ID: 1201bb95-d7df-449c-9dd8-9b8fc945098c
📥 Commits

Reviewing files that changed from the base of the PR and between 4fb1476 and 3a9caf6.

📒 Files selected for processing (5)
  • .github/workflows/install-smoke.yml
  • README.md
  • install.ps1
  • src/tests/README.md
  • src/tests/native/windows-install-terminal.py
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

Test coverage

✅ Gate passed — all 77 files are at or above the 95% floor.

Status Metric Coverage Threshold
✅ Functions 99.89% 95%
✅ Lines 99.53% 95%

@cb-muthiahm cb-muthiahm closed this Oct 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants