Skip to content

Release 2.7.2 - new payout destination types in payments (network token) - #230

Closed
david-ruiz-cko wants to merge 2 commits into
masterfrom
release/2.7.2
Closed

david-ruiz-cko wants to merge 2 commits into
masterfrom
release/2.7.2

Conversation

@david-ruiz-cko

Copy link
Copy Markdown
Contributor

This pull request enhances the documentation and expands the data models related to payout destinations, account holders, and card payout processing in the SDK. It introduces new classes, adds detailed attribute documentation, and improves the clarity and completeness of API model definitions, especially for payout and refund flows.

Model and Documentation Enhancements

  • Expanded and clarified attribute documentation for AccountHolder, AccountHolderIdentification, and various payout destination classes, specifying required/optional fields, expected formats, and deprecation notes. [1] [2] [3] [4] [5] [6] [7] [8]
  • Added missing or new enum values and types, such as NETWORK_TOKEN to DestinationType, and documented the use of these types across different payout and refund destinations.

New Classes for Payout Processing

  • Introduced CardPayoutProcessing to encapsulate affiliate and processing speed details for card payouts.
  • Added CardPayoutItem to represent individual items in a card payout, supporting item-level metadata.
  • Created InstructionRemittance for remittance details in bank payout instructions.
  • Added NetworkTokenDestination to support network token-based payout destinations.

Enum and Type Additions

  • Added ResidentialStatusType enum for account holders' residential status, and ensured it is required in relevant contexts. [1] [2]

These changes collectively improve the SDK’s support for complex payout and refund scenarios, increase type safety, and provide clearer guidance to developers integrating with the API.

Breaking changes ⚠️

  • PaymentType 'Moto' has been moved to the correct form 'MOTO'

@david-ruiz-cko
david-ruiz-cko requested a review from a team October 30, 2026 18:13
@agent-wall-e

agent-wall-e Bot commented Oct 30, 2026

Copy link
Copy Markdown

🟡 Risk Classification: MINOR

Approval route: AI Review + Human Approval
Rollback controls: Staged rollout + rollback

Classification reasons

  • no_low_class_matched
  • prod_source_modified

Operational gates

  • ✅ jira_ticket
  • ✅ independent_review

Files analysed: 1


wall-e 2026.06.19-02 · policy 6b4ce2b3b45a…

@agent-wall-e

agent-wall-e Bot commented Oct 30, 2026

Copy link
Copy Markdown
🔬 Debug — why this classification?

Each reason code emitted by the classifier, its source clause in the AI in SDLC Control Framework, and what it means.

Reason code Kind Clause Meaning
no_low_class_matched informational §2.2 (fall-through) None of the deterministic Low classes (§2.2.3, §2.2.4, §2.2.7, docs-only) applied; classifier fell through to LLM evaluation.
prod_source_modified informational §2.1 M7 (informational) At least one file is non-doc, non-test, non-IaC — i.e. application source code was modified.

Kinds:

  • classifying — this rule contributed to the chosen tier.
  • informational — context only; did not by itself decide the tier.

See issue #3 for the proposal to formalise this map as Appendix A of the standards doc.

wall-e 2026.06.19-02 · debug

@agent-wall-e

agent-wall-e Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

🟠 Advisory review: Concerns worth a look

This PR needs a human approval. Before you give it, these are the things I'd want resolved.

The PR claims to release version 2.7.2, but the diff bumps the version to 2.8.0 — a minor version increment rather than a patch version increment. This is a direct contradiction between the stated intent and the actual change.

Concerns

  • lib/checkout_sdk/version.rb: PR title says '2.7.2' but the version is being set to '2.8.0', which is a semver minor bump not a patch release — the human reviewer needs to confirm which version number is correct and intentional.

This is not an approval. wall-e cannot auto-approve this PR — it is an opinion to help whoever does. Advisory review · us.anthropic.claude-sonnet-4-6 · wall-e 2026.06.19-02

@david-ruiz-cko david-ruiz-cko changed the title Release 2.7.2 Release 2.7.2 - new payout destination types in payments (network token) Oct 30, 2026
@agent-wall-e

agent-wall-e Bot commented Nov 2, 2026

Copy link
Copy Markdown

🟡 Risk Classification: MINOR

Approval route: AI Review + Human Approval
Rollback controls: Staged rollout + rollback

Classification reasons

  • no_low_class_matched
  • prod_source_modified

Operational gates

  • ✅ jira_ticket
  • ✅ independent_review

Files analysed: 1


wall-e 2026.06.19-02 · policy 6b4ce2b3b45a…

@agent-wall-e

agent-wall-e Bot commented Nov 2, 2026

Copy link
Copy Markdown
🔬 Debug — why this classification?

Each reason code emitted by the classifier, its source clause in the AI in SDLC Control Framework, and what it means.

Reason code Kind Clause Meaning
no_low_class_matched informational §2.2 (fall-through) None of the deterministic Low classes (§2.2.3, §2.2.4, §2.2.7, docs-only) applied; classifier fell through to LLM evaluation.
prod_source_modified informational §2.1 M7 (informational) At least one file is non-doc, non-test, non-IaC — i.e. application source code was modified.

Kinds:

  • classifying — this rule contributed to the chosen tier.
  • informational — context only; did not by itself decide the tier.

See issue #3 for the proposal to formalise this map as Appendix A of the standards doc.

wall-e 2026.06.19-02 · debug

@sonarqubecloud

sonarqubecloud Bot commented Nov 2, 2026

Copy link
Copy Markdown

@david-ruiz-cko

Copy link
Copy Markdown
Contributor Author

Abandoned, will go to a minor version, not a patch

@david-ruiz-cko
david-ruiz-cko deleted the release/2.7.2 branch November 2, 2026 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant