Repository navigation
refactor - #18
Merged
Merged
refactor#18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
src/util.rs.codegen/mod.rs,codegen/record.rs,traits/proxy.rsandutil.rsnow use those helpers instead of hand-editing prefixes.generate_wrapped_witssplit in two. It used to do two jobs. Now one function buildsconversion.wit(all modes) and another builds thewrapped-*packages (Record mode only). Both are called fromgenerate_componentand hand their files back like everything else, instead of writing to disk themselves.generate_wac;load_importsandload_exportsshare one function for reading a component's imports.LinkInfoand its unused fields are replaced by four plainly named maps/sets.magic42inget-mock-conversion function by storing the type alias in the bindgen code, and extract the last segment in the full path.