Skip to content

Simplify check recording and JSON expectation validation - #3

Merged
choidanny719 merged 2 commits into
mainfrom
refactor-monitor-internals
Oct 3, 2026
Merged

choidanny719 merged 2 commits into
mainfrom
refactor-monitor-internals

Conversation

@choidanny719

Copy link
Copy Markdown
Owner

Check recording mixes health updates, incident handling, and history cleanup in one transaction callback. JSON expectation validation also puts its shape, path, and value rules into a single long condition.

This refactor:

  • Moves health updates and history cleanup into private Store helpers while preserving the existing transaction boundary.
  • Separates JSON path and value checks from monitor configuration validation, preserving accepted inputs and error messages.
  • Adds regression coverage for incident-write rollback, per-monitor retention, and JSON expectation boundaries.

README, endpoints, features, schema, dependencies, and configuration defaults are unchanged. The changes are split into two commits by area.

Validation: all 28 tests pass with npm test, npm run demo passes, and git diff --check is clean. The new regression cases also passed against the original implementation before each refactor.

@choidanny719
choidanny719 merged commit 392b0c8 into main Oct 3, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant