Repository navigation
Cover monitor edge cases and handle listen failures - #4
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing suite missed exact limits, malformed history parameters, real TLS failures, and startup errors. The new occupied-port test exposed a bug: Express passed a listen error to the callback, but the server still announced startup and ran the scheduler.
This PR adds 16 tests and handles that listen error by reporting it, closing the database, and exiting with code 1 before scheduling checks.
TLS tests use the OpenSSL CLI to generate temporary certificates and keys, then remove them. No key material is committed.
Validation: all 44 tests and the demo pass locally and in GitHub CI. The README is unchanged.