Repository navigation
Expand checker, incident and scheduling test coverage - #5
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several monitor behaviors lacked regression coverage, particularly configuration changes during running checks and failures while saving or pruning history.
Adds tests for:
Changes are split into three commits and touch only five test files. Application behavior, README, dependencies and CI configuration are unchanged.
Validation: 89 tests pass, up from 44;
npm run demopasses. Node's coverage report shows 100% source line coverage and 97.72% branch coverage. These measurements do not imply every possible input or execution order is covered.