Conversation
|
Did you check this MacOS build in github, should work out of the box |
It works, because CI prefixes PATH. If user doesn't install bison from brew / install it without prefixing PATH, it will fallback to default Mac bison 2.3 FastBinaryEncoding/.github/workflows/build-macos.yml Lines 19 to 22 in 7347014 Here's an example failing build using this commit e37a47f - https://github.com/Andrej730/FastBinaryEncoding/actions/runs/36319928061/job/108621678066 |
|
Since instead of In case flex is missing. Unsure if there's any particular version requirement for flex, so the version is omitted. |
Hi! Adding bison requirement to cmake to catch errors like #27 early, during configuration.
Either way, bison is already required, building without it breaks at configuration stage:
With
2.5 REQUIREDit now will result in:Or if bison is found (important on Mac, which is stuck on 2.3 and would break during the build with more obscure
invalid option -- W):Why 2.5:
invalid option -- Winvalid argument no-conflicts-rr for --warnings@chronoxor can you please take a look?