Repository navigation
Source vaillant_ebus: time programs through the Vaillant eBUS integration - #2
Merged
Merged
Conversation
…t eBUS integration instead of MQTT - new options source (mqtt | vaillant_ebus), refresh_interval, entry_id - adapters/vaillant-ebus.ts: read_time_program / write_time_program actions, one shared read per program for all cards - write job: a day can be written by an action that reads it back itself - fake integration on the dev page (?source=vaillant_ebus), unit and browser smoke tests - three new texts in all languages, options documented
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
A second data source next to MQTT: with
source: vaillant_ebusthe card reads and writes the time programs through theVaillant eBUS integration, which talks to ebusd over TCP. No MQTT and no
sensor per slot needed.
Depends on MarkBovee/vaillant-ebus#229, which adds the
read_time_programandwrite_time_programactions. Untilthat is released,
source: vaillant_ebusshows "not found" with a hint; the MQTT source (default) is unchanged.How
source(mqtt|vaillant_ebus),refresh_interval(default 300 s, reads from ebusd's cache) andentry_id(only with several integration entries).src/adapters/vaillant-ebus.ts: calls the actions withreturnResponse; one shared read per program for all cardson the page; a failed read keeps the last values (offline) and is retried after 30 s.
setback_entitywith this source (no MQTT write).?source=vaillant_ebususes a fake integration intest/fake-ebusd.ts.docs/options.mdhas a new "Source" section.Tests
npm test: 168 tests (17 new),npm run typecheckclean.npm run test:e2e: all 9 checks, 2 new for thevaillant_ebussource (write, and a day the controller ignores).(CTLV2 SW0514). Read and write worked; the MQTT card on the production system showed the changes shortly after.