#198 - Fix DateParserTransformer - #209
Merged
Merged
Conversation
…e` input is converted to a `\DateTime` instead of throwing a `TypeError`. Update documentation, add tests. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #198.
DateParserTransformerfails with aTypeErrorwhen its input is a\DateTimeImmutable: only\DateTimeobjects are returned as-is, any other value is passed to\DateTime::createFromFormat().This PR:
\DateTimeImmutableinput to a\DateTimewith\DateTime::createFromImmutable()(same date, time and timezone), so that the transformer keeps its contract of always outputting a\DateTime;docs/reference/transformers/date_parser_transformer.md(Accepted inputs, remove the Notes entry).The new regression tests fail on
mainand pass with this fix. PHPUnit, PHPStan, PHP-CS-Fixer and Rector pass.Requirements
Breaking changes
None: a
\DateTimeImmutableinput currently always fails.🤖 Generated with Claude Code