#200 - Fix GenericTransformer - #211
Merged
Merged
Conversation
…lared with `required: false` and no default can now be used; its placeholders are replaced by `null` when omitted. Update documentation, add tests. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
3 tasks
…ng risky tests when coverage is enabled Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #200.
A contextual option of a generic transformer declared with
required: falseand nodefault(nordefault_is_null) cannot be used at all: it is neither required nor defined in the transformer options resolver, so passing it throws anUndefinedOptionsException, and omitting it throws aNoSuchOptionExceptionwhen the placeholders are resolved.This PR:
setDefined();null;GenericTransformer(required option, option with default, optional option provided / omitted);docs/reference/transformers/generic_transformer.md(Notes) anddocs/reference/03-generic_transformers_definition.md.The new regression tests fail on
mainand pass with this fix. PHPUnit, PHPStan, PHP-CS-Fixer and Rector pass.Requirements
Breaking changes
None: such an option currently always fails.
🤖 Generated with Claude Code