#201 - Fix minor defects - #212
Merged
Merged
Conversation
…rait, RulesTransformer and ExpressionLanguageMapTransformer, useless `setRequired()` in ImplodeTransformer and SprintfTransformer, stray namespace in TrimTransformer, wrong or missing docblocks. Add tests. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…ng risky tests when coverage is enabled Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #201.
Minor defects found while writing the reference documentation (#145), without major functional impact: wrong error messages, dead code, stray namespace, and wrong or
@tododocblocks.TransformerTrait::normalizeTransformers()"Transformer {${$origTransformerCode}} should not have options"uses a variable variable: the transformer name is lost in the message and anUndefined variablePHP warning is raisedTrimTransformernamespace Transformer;line before the real namespaceRulesTransformer::configureOptions()ImplodeTransformer,SprintfTransformersetRequired()+setDefault()on the same option: "required" has no effect (the documentation already lists these options as not required)ExpressionLanguageMapTransformer::transform()Array to string conversionwarning, for an object without__toString()anErrorreplaces the expectedUnexpectedValueExceptionProcessExecutorTaskFilterTaskConditionTraituses===RowAggregatorTaskInputAggregatorTaskColumnAggregatorTask,DefaultTransformer@todoinstead of a descriptionRecursivePropertySetterTransformerPropertyAccessorTransformer, misspelled variables ($protertiesToSet…)DateFormatTransformer\DateTimeInterfaceThis PR:
TransformerTrait,RulesTransformer,ExpressionLanguageMapTransformer: display the value if scalar or\Stringable, its type otherwise);setRequired()calls;RulesTransformer,TransformerTrait,ExpressionLanguageMapTransformer).Not included (behaviour change to discuss separately): the
callback#<n>suffix regex ofTransformerTrait::getCleanedTransfomerCode()is not anchored, socallback#foois accepted.The new regression tests fail on
mainand pass with this fix. PHPUnit, PHPStan, PHP-CS-Fixer and Rector pass.Requirements
Breaking changes
None.
ImplodeTransformer/SprintfTransformer:OptionsResolver::isRequired('separator'|'format')now returnsfalse, which only affects code introspecting the resolver.🤖 Generated with Claude Code